Changeset 96141 in vbox for trunk/src/VBox/Main/src-server/SystemPropertiesImpl.cpp

Timestamp:

Aug 11, 2022 3:37:19 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

152947

Message:

Recording/Main:

• Renamed RecordingVideoScalingMethod -> RecordingVideoScalingMode (to match the other enums).
• Renamed RecordingVideoRateControlMode -> RecordingRateControlMode, as this also can apply to audio codecs.
• Added ABR (average bitrate) mode to RecordingRateControlMode.

IRecordingScreenSettings:

• Added audioRateControlMode.
• Added videoScalingMode.

ISystemProperties:

• Renamed supportedRecordingVSMethods to supportedRecordingVSModes (to match RecordingVideoScalingMode).
• Added supportedRecordingARCModes.

Renamed com::settings::RecordingScreenSettings.Audio.enmAudioCodec -> .enmCodec (Doppelmoppel).

More documentation.

​bugref:10275

File:

• trunk/src/VBox/Main/src-server/SystemPropertiesImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-server/SystemPropertiesImpl.cpp

@@ -1601 +1601 @@
         RecordingAudioCodec_WavPCM,
 #endif
+#ifdef VBOX_WITH_LIBOPUS
         RecordingAudioCodec_Opus,
+#endif
+#ifdef VBOX_WITH_LIBVORBIS
+        RecordingAudioCodec_OggVorbis,
+#endif
     };
     aSupportedRecordingAudioCodecs.assign(aRecordingAudioCodecs,
@@ -1623 +1628 @@
 }
 
-HRESULT SystemProperties::getSupportedRecordingVSMethods(std::vector<RecordingVideoScalingMethod_T> &aSupportedRecordingVideoScalingMethods)
-{
-    static const RecordingVideoScalingMethod_T aRecordingVideoScalingMethods[] =
-    {
-        RecordingVideoScalingMethod_None,
+HRESULT SystemProperties::getSupportedRecordingVSModes(std::vector<RecordingVideoScalingMode_T> &aSupportedRecordingVideoScalingModes)
+{
+    static const RecordingVideoScalingMode_T aRecordingVideoScalingModes[] =
+    {
+        RecordingVideoScalingMode_None,
 #ifdef DEBUG
-        RecordingVideoScalingMethod_NearestNeighbor,
-        RecordingVideoScalingMethod_Bilinear,
-        RecordingVideoScalingMethod_Bicubic,
-#endif
-    };
-    aSupportedRecordingVideoScalingMethods.assign(aRecordingVideoScalingMethods,
-                                                  aRecordingVideoScalingMethods + RT_ELEMENTS(aRecordingVideoScalingMethods));
-    return S_OK;
-}
-
-HRESULT SystemProperties::getSupportedRecordingVRCModes(std::vector<RecordingVideoRateControlMode_T> &aSupportedRecordingVideoRateControlModes)
-{
-    static const RecordingVideoRateControlMode_T aRecordingVideoRateControlModes[] =
-    {
-        RecordingVideoRateControlMode_CBR,
+        RecordingVideoScalingMode_NearestNeighbor,
+        RecordingVideoScalingMode_Bilinear,
+        RecordingVideoScalingMode_Bicubic,
+#endif
+    };
+    aSupportedRecordingVideoScalingModes.assign(aRecordingVideoScalingModes,
+                                                aRecordingVideoScalingModes + RT_ELEMENTS(aRecordingVideoScalingModes));
+    return S_OK;
+}
+
+HRESULT SystemProperties::getSupportedRecordingARCModes(std::vector<RecordingRateControlMode_T> &aSupportedRecordingAudioRateControlModes)
+{
+    static const RecordingRateControlMode_T aRecordingAudioRateControlModes[] =
+    {
 #ifdef DEBUG
-        RecordingVideoRateControlMode_VBR,
-#endif
+        RecordingRateControlMode_ABR,
+        RecordingRateControlMode_CBR,
+#endif
+        RecordingRateControlMode_VBR
+    };
+    aSupportedRecordingAudioRateControlModes.assign(aRecordingAudioRateControlModes,
+                                                    aRecordingAudioRateControlModes + RT_ELEMENTS(aRecordingAudioRateControlModes));
+    return S_OK;
+}
+
+HRESULT SystemProperties::getSupportedRecordingVRCModes(std::vector<RecordingRateControlMode_T> &aSupportedRecordingVideoRateControlModes)
+{
+    static const RecordingRateControlMode_T aRecordingVideoRateControlModes[] =
+    {
+#ifdef DEBUG
+        RecordingRateControlMode_ABR,
+        RecordingRateControlMode_CBR,
+#endif
+        RecordingRateControlMode_VBR
     };
     aSupportedRecordingVideoRateControlModes.assign(aRecordingVideoRateControlModes,