Changeset 89620 in vbox for trunk/src/VBox/VMM/VMMR3/PDMDevHlp.cpp

Timestamp:

Jun 11, 2021 8:51:10 AM (4 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

145064

Message:

Intel IOMMU: bugref:9967 Allow PDMIoApicSetEoi operation to be queued to ring-3 if I/O APIC isn't available in R0.
This key change is taking the PDM lock such that it doesn't fail (VINF_SUCCESS instead of VINF_IOM_R3_MMIO_WRITE for rcBusy, which wouldn't have worked anyway when called via APICHvSetEoi for instance).
Also cleaned up the prototype of PDMIoApicSendMsi a bit (use PVMCC instead of PPDMDEVINS).

File:

• trunk/src/VBox/VMM/VMMR3/PDMDevHlp.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMR3/PDMDevHlp.cpp

@@ -5371 +5371 @@
             if (pPciDev)
             {
-                size_t const    idxBus = pPciDev->Int.s.idxPdmBus;
+                size_t const idxBus = pPciDev->Int.s.idxPdmBus;
                 AssertBreak(idxBus < RT_ELEMENTS(pVM->pdm.s.aPciBuses));
-                PPDMPCIBUS      pBus   = &pVM->pdm.s.aPciBuses[idxBus];
+                PPDMPCIBUS   pBus   = &pVM->pdm.s.aPciBuses[idxBus];
 
                 pdmLock(pVM);
@@ -5394 +5394 @@
         case PDMDEVHLPTASKOP_IOAPIC_SEND_MSI:
         {
-            Assert(pTask->pDevInsR3);
-            PDMIoApicSendMsi(pTask->pDevInsR3, pTask->u.IoApicSendMsi.uBusDevFn, &pTask->u.IoApicSendMsi.Msi,
-                             pTask->u.IoApicSendMsi.uTagSrc);
+            PDMIoApicSendMsi(pVM, pTask->u.IoApicSendMsi.uBusDevFn, &pTask->u.IoApicSendMsi.Msi, pTask->u.IoApicSendMsi.uTagSrc);
+            break;
+        }
+
+        case PDMDEVHLPTASKOP_IOAPIC_SET_EOI:
+        {
+            PDMIoApicBroadcastEoi(pVM, pTask->u.IoApicSetEoi.uVector);
             break;
         }