Changeset 82088 in vbox for trunk/src/VBox/Devices/Graphics/DevVGA_VBVA.cpp

Timestamp:

Nov 21, 2019 9:59:57 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

134895

Message:

DevVGA: Mark functions with R3 where appropriate, adding docs and doing other minor cleaning up. bugref:9218

File:

• trunk/src/VBox/Devices/Graphics/DevVGA_VBVA.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Graphics/DevVGA_VBVA.cpp

@@ -892 +892 @@
     {
         Assert(pCommand->Flags & VBOXVHWACMD_FLAG_HG_ASYNCH);
-        vbvaVHWACommandCompleteAsync(&pVGAState->IVBVACallbacks, pCommand);
+        vbvaR3VHWACommandCompleteAsync(&pVGAState->IVBVACallbacks, pCommand);
     }
     else
@@ -1355 +1355 @@
  * @interface_method_impl{PDMIDISPLAYVBVACALLBACKS,pfnVHWACommandCompleteAsync}
  */
-DECLCALLBACK(int) vbvaVHWACommandCompleteAsync(PPDMIDISPLAYVBVACALLBACKS pInterface, VBOXVHWACMD RT_UNTRUSTED_VOLATILE_GUEST *pCmd)
+DECLCALLBACK(int) vbvaR3VHWACommandCompleteAsync(PPDMIDISPLAYVBVACALLBACKS pInterface,
+                                                 VBOXVHWACMD RT_UNTRUSTED_VOLATILE_GUEST *pCmd)
 {
     PVGASTATE pVGAState = PPDMIDISPLAYVBVACALLBACKS_2_PVGASTATE(pInterface);
@@ -2080 +2081 @@
 }
 
-void VBVARaiseIrq (PVGASTATE pVGAState, uint32_t fFlags)
+void VBVARaiseIrq(PVGASTATE pVGAState, uint32_t fFlags)
 {
     PPDMDEVINS pDevIns = pVGAState->pDevInsR3;
@@ -2787 +2788 @@
 #define IDISPLAYPORT_2_VGASTATE(pInterface) ( (PVGASTATE)((uintptr_t)pInterface - RT_OFFSETOF(VGASTATE, IPort)) )
 
-DECLCALLBACK(int) vbvaPortSendModeHint(PPDMIDISPLAYPORT pInterface, uint32_t cx,
-                                       uint32_t cy, uint32_t cBPP,
-                                       uint32_t iDisplay, uint32_t dx,
-                                       uint32_t dy, uint32_t fEnabled,
-                                       uint32_t fNotifyGuest)
-{
-    PVGASTATE pThis;
-    int rc;
-
-    pThis = IDISPLAYPORT_2_VGASTATE(pInterface);
-    rc = PDMDevHlpCritSectEnter(pThis->pDevInsR3, &pThis->CritSect, VERR_SEM_BUSY);
+/**
+ * @interface_method_impl{PDMIDISPLAYPORT,pfnSendModeHint}
+ */
+DECLCALLBACK(int) vbvaR3PortSendModeHint(PPDMIDISPLAYPORT pInterface,  uint32_t cx, uint32_t cy, uint32_t cBPP,
+                                         uint32_t iDisplay, uint32_t dx, uint32_t dy, uint32_t fEnabled, uint32_t fNotifyGuest)
+{
+    PVGASTATE pThis = IDISPLAYPORT_2_VGASTATE(pInterface);
+    int rc = PDMDevHlpCritSectEnter(pThis->pDevInsR3, &pThis->CritSect, VERR_SEM_BUSY);
     AssertRC(rc);
-    rc = vbvaSendModeHintWorker(pThis, cx, cy, cBPP, iDisplay, dx, dy, fEnabled,
-                                fNotifyGuest);
+
+    rc = vbvaSendModeHintWorker(pThis, cx, cy, cBPP, iDisplay, dx, dy, fEnabled, fNotifyGuest);
+
     PDMDevHlpCritSectLeave(pThis->pDevInsR3, &pThis->CritSect);
     return rc;