Changeset 79087 in vbox for trunk/src/VBox/ValidationKit/testmanager/core/testbox.py

Timestamp:

Jun 11, 2019 11:58:28 AM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

131247

Message:

ValKit: New pylint version - cleanup in progress.

File:

• trunk/src/VBox/ValidationKit/testmanager/core/testbox.py (modified) (10 diffs)

trunk/src/VBox/ValidationKit/testmanager/core/testbox.py

@@ -99 +99 @@
     def __init__(self):
         TestBoxInSchedGroupData.__init__(self);
-        self.oSchedGroup        = None; # type: SchedGroupData
+        self.oSchedGroup        = None  # type: SchedGroupData
 
     def initFromDbRowEx(self, aoRow, oDb, tsNow = None, sPeriodBack = None):
@@ -111 +111 @@
 
 
-# pylint: disable=C0103
-class TestBoxData(ModelDataBase):  # pylint: disable=R0902
+# pylint: disable=invalid-name
+class TestBoxData(ModelDataBase):  # pylint: disable=too-many-instance-attributes
     """
     TestBox Data.
@@ -476 +476 @@
             if uFam == 0xf:
                 if uMod < 0x10:                             return 'K8_130nm';
-                if uMod >= 0x60 and uMod < 0x80:            return 'K8_65nm';
+                if 0x60 <= uMod < 0x80:                     return 'K8_65nm';
                 if uMod >= 0x40:                            return 'K8_90nm_AMDV';
                 if uMod in [0x21, 0x23, 0x2b, 0x37, 0x3f]:  return 'K8_90nm_DualCore';
@@ -567 +567 @@
     def __init__(self):
         TestBoxData.__init__(self);
-        self.aoInSchedGroups        = [];   # type: list[TestBoxInSchedGroupData]
+        self.aoInSchedGroups        = []    # type: list[TestBoxInSchedGroupData]
 
     def _initExtraMembersFromDb(self, oDb, tsNow = None, sPeriodBack = None):
@@ -634 +634 @@
         return aoNewValues;
 
-    def _validateAndConvertAttribute(self, sAttr, sParam, oValue, aoNilValues, fAllowNull, oDb): # pylint: disable=R0914
+    def _validateAndConvertAttribute(self, sAttr, sParam, oValue, aoNilValues, fAllowNull, oDb): # pylint: disable=too-many-locals
         """
         Validate special arrays and requirement expressions.
@@ -773 +773 @@
                 TestBoxDataEx.__init__(self);
                 self.tsCurrent = None;  # CURRENT_TIMESTAMP
-                self.oStatus   = None;  # type: TestBoxStatusData
+                self.oStatus   = None   # type: TestBoxStatusData
 
         from testmanager.core.testboxstatus import TestBoxStatusData;
@@ -811 +811 @@
         return aoRows;
 
-    def fetchForChangeLog(self, idTestBox, iStart, cMaxRows, tsNow): # pylint: disable=R0914
+    def fetchForChangeLog(self, idTestBox, iStart, cMaxRows, tsNow): # pylint: disable=too-many-locals
         """
         Fetches change log entries for a testbox.
@@ -1013 +1013 @@
 
 
-    def updateOnSignOn(self, idTestBox, idGenTestBox, sTestBoxAddr, sOs, sOsVersion, # pylint: disable=R0913,R0914
+    def updateOnSignOn(self, idTestBox, idGenTestBox, sTestBoxAddr, sOs, sOsVersion, # pylint: disable=too-many-arguments,too-many-locals
                        sCpuVendor, sCpuArch, sCpuName, lCpuRevision, cCpus, fCpuHwVirt, fCpuNestedPaging, fCpu64BitGuest,
                        fChipsetIoMmu, fRawMode, cMbMemory, cMbScratch, sReport, iTestBoxScriptRev, iPythonHexVersion):
@@ -1153 +1153 @@
         except TMInFligthCollision:
             return False;
-        except:
-            raise;
         return True;
 
@@ -1177 +1175 @@
 #
 
-# pylint: disable=C0111
+# pylint: disable=missing-docstring
 class TestBoxDataTestCase(ModelDataBaseTestCase):
     def setUp(self):