Changeset 74446 in vbox for trunk/src/VBox/Devices/Serial/DrvHostSerial.cpp

Timestamp:

Sep 24, 2018 4:05:11 PM (7 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

125293

Message:

Devices/Serial: Add callback to flush receive/transmit queues of the underlying driver when the serial device flushes the internal queues to stay in sync. Should fix hanging serial I/O under certain circumstances (Debugging a Windows 7 guest over a serial port attached to a named pipe for example)

File:

• trunk/src/VBox/Devices/Serial/DrvHostSerial.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Serial/DrvHostSerial.cpp

@@ -355 +355 @@
 
     return RTSerialPortQueryStatusLines(pThis->hSerialPort, pfStsLines);
+}
+
+
+/**
+ * @callback_method_impl{PDMISERIALCONNECTOR,pfnQueuesFlush}
+ */
+static DECLCALLBACK(int) drvHostSerialQueuesFlush(PPDMISERIALCONNECTOR pInterface, bool fQueueRecv, bool fQueueXmit)
+{
+    RT_NOREF(fQueueXmit);
+    LogFlowFunc(("pInterface=%#p fQueueRecv=%RTbool fQueueXmit=%RTbool\n", pInterface, fQueueRecv, fQueueXmit));
+    int rc = VINF_SUCCESS;
+    PDRVHOSTSERIAL pThis = RT_FROM_MEMBER(pInterface, DRVHOSTSERIAL, ISerialConnector);
+
+    if (fQueueRecv)
+    {        
+        size_t cbOld = 0;
+        ASMAtomicXchgSizeCorrect(&pThis->cbReadBuf, 0, &cbOld);
+        if (cbOld) /* Kick the I/O thread to fetch new data. */
+            rc = RTSerialPortEvtPollInterrupt(pThis->hSerialPort);
+    }
+
+    LogFlowFunc(("-> %Rrc\n", rc));
+    return VINF_SUCCESS;
 }
 
@@ -582 +605 @@
     pThis->ISerialConnector.pfnChgBrk            = drvHostSerialChgBrk;
     pThis->ISerialConnector.pfnQueryStsLines     = drvHostSerialQueryStsLines;
+    pThis->ISerialConnector.pfnQueuesFlush       = drvHostSerialQueuesFlush;
 
     /*