Changeset 67885 in vbox for trunk/src/VBox/Main/src-server/SnapshotImpl.cpp

Timestamp:

Jul 10, 2017 4:45:06 PM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

116851

Message:

Main/Snapshot: detect if snapshot merging would lose data due to capacity differences, and error out if necessary

File:

• trunk/src/VBox/Main/src-server/SnapshotImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/SnapshotImpl.cpp

@@ -2805 +2805 @@
             // base image. Important e.g. for medium formats which do not have
             // a file representation such as iSCSI.
+
+            // not going to merge a big source into a small target
+            if (pSource->i_getLogicalSize() > pTarget->i_getLogicalSize())
+            {
+                rc = setError(E_FAIL,
+                              tr("Unable to merge storage '%s', because it is smaller than the source image. If you resize it to have a capacity of at least %lld bytes you can retry"),
+                              pTarget->i_getLocationFull().c_str(), pSource->i_getLogicalSize());
+                throw rc;
+            }
 
             // a couple paranoia checks for backward merges