Changeset 65980 in vbox for trunk/src/VBox/ValidationKit/testmanager/core/testgroup.py

Timestamp:

Mar 7, 2017 1:00:36 PM (8 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

113806

Message:

testmanager/core: pylint 2.0.0 fixes.

File:

• trunk/src/VBox/ValidationKit/testmanager/core/testgroup.py (modified) (6 diffs)

trunk/src/VBox/ValidationKit/testmanager/core/testgroup.py

@@ -353 +353 @@
 
             dErrors = oNewMember.validateAndConvert(oDb, ModelDataBase.ksValidateFor_Other);
-            if len(dErrors) > 0:
+            if dErrors:
                 asErrors.append(str(dErrors));
 
-        if len(asErrors) == 0:
+        if not asErrors:
             for i, _ in enumerate(aoNewMembers):
                 idTestCase = aoNewMembers[i];
@@ -364 +364 @@
                         break;
 
-        return (aoNewMembers, None if len(asErrors) == 0 else '<br>\n'.join(asErrors));
+        return (aoNewMembers, None if not asErrors else '<br>\n'.join(asErrors));
 
 
@@ -419 +419 @@
         assert isinstance(oData, TestGroupDataEx);
         dErrors = oData.validateAndConvert(self._oDb, oData.ksValidateFor_Add);
-        if len(dErrors) > 0:
+        if dErrors:
             raise TMInvalidData('addEntry invalid input: %s' % (dErrors,));
         self._assertUniq(oData, None);
@@ -453 +453 @@
         assert isinstance(oData, TestGroupDataEx);
         dErrors = oData.validateAndConvert(self._oDb, oData.ksValidateFor_Edit);
-        if len(dErrors) > 0:
+        if dErrors:
             raise TMInvalidData('editEntry invalid input: %s' % (dErrors,));
         self._assertUniq(oData, oData.idTestGroup);
@@ -502 +502 @@
                                           '   AND tsExpire    = \'infinity\'::TIMESTAMP\n'
                                           , ( oData.idTestGroup, ));
-        if len(dNew) > 0:
-            sQuery += '   AND idTestCase NOT IN (%s)' % (', '.join([str(iKey) for iKey in dNew.keys()]),);
+        if dNew:
+            sQuery += '   AND idTestCase NOT IN (%s)' % (', '.join([str(iKey) for iKey in dNew]),);
         self._oDb.execute(sQuery);
 
@@ -527 +527 @@
                               , ( idTestGroup, ));
             aoGroups = self._oDb.fetchAll();
-            if len(aoGroups) > 0:
+            if aoGroups:
                 asGroups = ['%s (#%d)' % (sName, idSchedGroup) for idSchedGroup, sName in aoGroups];
                 raise TMRowInUse('Test group #%d is member of one or more scheduling groups: %s'