Changeset 55233 in vbox for trunk/src/VBox/Main/src-server/SnapshotImpl.cpp

Timestamp:

Apr 14, 2015 9:07:45 AM (10 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

99544

Message:

Main/Machine+Snapshot: fix state checks and introduce standardized state checks for snapshot operations as a safety net

File:

• trunk/src/VBox/Main/src-server/SnapshotImpl.cpp (modified) (5 diffs)

trunk/src/VBox/Main/src-server/SnapshotImpl.cpp

@@ -1430 +1430 @@
                         Global::stringifyMachineState(mData->mMachineState));
 
-    HRESULT rc = S_OK;
+    HRESULT rc = i_checkStateDependency(MutableOrSavedOrRunningStateDep);
+    if (FAILED(rc))
+        return rc;
 
     // prepare the progress object:
@@ -1584 +1586 @@
         {
             Bstr value;
-            HRESULT rc = GetExtraData(Bstr("VBoxInternal2/ForceTakeSnapshotWithoutState").raw(),
-                                      value.asOutParam());
+            rc = GetExtraData(Bstr("VBoxInternal2/ForceTakeSnapshotWithoutState").raw(),
+                              value.asOutParam());
             if (FAILED(rc) || value != "1")
                 // creating a new online snapshot: we need a fresh saved state file
@@ -1951 +1953 @@
                         Global::stringifyMachineState(mData->mMachineState));
 
+    HRESULT rc = i_checkStateDependency(MutableOrSavedStateDep);
+    if (FAILED(rc))
+        return rc;
+
     ISnapshot* iSnapshot = aSnapshot;
     ComObjPtr<Snapshot> pSnapshot(static_cast<Snapshot*>(iSnapshot));
     ComObjPtr<SnapshotMachine> pSnapMachine = pSnapshot->i_getSnapshotMachine();
-
-    HRESULT rc = S_OK;
 
     // create a progress object. The number of operations is:
@@ -2351 +2355 @@
     AssertReturn(!aStartId.isZero() && !aEndId.isZero() && aStartId.isValid() && aEndId.isValid(), E_INVALIDARG);
 
-
     /** @todo implement the "and all children" and "range" variants */
     if (aDeleteAllChildren || aStartId != aEndId)
@@ -2375 +2378 @@
                         Global::stringifyMachineState(mData->mMachineState));
 
+    HRESULT rc = i_checkStateDependency(MutableOrSavedOrRunningStateDep);
+    if (FAILED(rc))
+        return rc;
+
     ComObjPtr<Snapshot> pSnapshot;
-    HRESULT rc = i_findSnapshotById(aStartId, pSnapshot, true /* aSetError */);
-    if (FAILED(rc)) return rc;
+    rc = i_findSnapshotById(aStartId, pSnapshot, true /* aSetError */);
+    if (FAILED(rc))
+        return rc;
 
     AutoWriteLock snapshotLock(pSnapshot COMMA_LOCKVAL_SRC_POS);