Changeset 40806 in vbox for trunk/src/VBox/Runtime/common/misc/handletable.cpp

Timestamp:

Apr 6, 2012 9:05:19 PM (13 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

77321

Message:

RTSpinlock: Redid the interface, eliminating NoInts and Tmp. Whether a spinlock is interrupt safe or not is now defined at creation time, preventing stupid bugs arrising from calling the wrong acquire and/or release methods somewhere. The saved flags are stored in the spinlock strucutre, eliminating the annoying Tmp variable. Needs testing on each platform before fixing the build burn.

File:

• trunk/src/VBox/Runtime/common/misc/handletable.cpp (modified) (3 diffs)

trunk/src/VBox/Runtime/common/misc/handletable.cpp

@@ -103 +103 @@
     if (fFlags & RTHANDLETABLE_FLAGS_LOCKED)
     {
-        int rc = RTSpinlockCreate(&pThis->hSpinlock);
+        int rc = RTSpinlockCreate(&pThis->hSpinlock, RTSPINLOCK_FLAGS_INTERRUPT_UNSAFE, "RTHandleTableCreateEx");
         if (RT_FAILURE(rc))
         {
@@ -127 +127 @@
 {
     PRTHANDLETABLEINT   pThis;
-    RTSPINLOCKTMP       Tmp = RTSPINLOCKTMP_INITIALIZER;
     uint32_t            i1;
     uint32_t            i;
@@ -145 +144 @@
      * Then kill the lock.
      */
-    rtHandleTableLock(pThis, &Tmp);
+    rtHandleTableLock(pThis);
     ASMAtomicWriteU32(&pThis->u32Magic, ~RTHANDLETABLE_MAGIC);
-    rtHandleTableUnlock(pThis, &Tmp);
+    rtHandleTableUnlock(pThis);
 
     if (pThis->hSpinlock != NIL_RTSPINLOCK)
     {
-        rtHandleTableLock(pThis, &Tmp);
-        rtHandleTableUnlock(pThis, &Tmp);
+        rtHandleTableLock(pThis);
+        rtHandleTableUnlock(pThis);
 
         RTSpinlockDestroy(pThis->hSpinlock);