Changeset 40257 in vbox for trunk/src/VBox/Main/src-client/ConsoleImplTeleporter.cpp

Timestamp:

Feb 27, 2012 9:25:12 AM (13 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

76471

Message:

Main/Medium: rework locking scheme to solve lock order violations and long GUI start up time caused by too much locking
Main/all: Remove the enter and leave methods from write locks, they cause hard to find locking problems. Better solve them explicitly.

File:

• trunk/src/VBox/Main/src-client/ConsoleImplTeleporter.cpp (modified) (3 diffs)

trunk/src/VBox/Main/src-client/ConsoleImplTeleporter.cpp

@@ -5 +5 @@
 
 /*
- * Copyright (C) 2010 Oracle Corporation
+ * Copyright (C) 2010-2012 Oracle Corporation
  *
  * This file is part of VirtualBox Open Source Edition (OSE), as
@@ -886 +886 @@
                         if (pState->mfSuspendedByUs)
                         {
-                            autoLock.leave();
+                            autoLock.release();
                             int rc = VMR3Resume(VMR3GetVM(pState->mpUVM));
                             AssertLogRelMsgRC(rc, ("VMR3Resume -> %Rrc\n", rc));
-                            autoLock.enter();
+                            autoLock.acquire();
                         }
                     }
@@ -901 +901 @@
         }
     }
-    autoLock.leave();
+    autoLock.release();
 
     /*