Changeset 23869 in vbox for trunk/src/VBox/Runtime/r3/posix/process-posix.cpp

Timestamp:

Oct 19, 2009 2:32:57 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

53640

Message:

fix/hack waitpid issues for unix platforms: racing of RT and xpcom, make waitpid for terminated child processes

File:

• trunk/src/VBox/Runtime/r3/posix/process-posix.cpp (modified) (3 diffs)

trunk/src/VBox/Runtime/r3/posix/process-posix.cpp

@@ -110 +110 @@
     /*
      * Spawn the child.
+     *
+     * HACK ALERT! Put the process into a new process group with pgid = pid
+     * to make sure it differs from that of the parent process to ensure that
+     * the IPRT waipit call doesn't race anyone (read XPCOM) doing group wide
+     * waits.
      */
     pid_t pid;
@@ -115 +120 @@
     if (!(fFlags & RTPROC_FLAGS_DAEMONIZE))
     {
-        /** @todo check if it requires any of those two attributes, don't remember atm. */
-        rc = posix_spawn(&pid, pszExec, NULL, NULL, (char * const *)papszArgs,
-                         (char * const *)papszEnv);
+        posix_spawnattr_t Attr;
+
+        rc = posix_spawnattr_init(&Attr);
         if (!rc)
         {
-            if (pProcess)
-                *pProcess = pid;
-            return VINF_SUCCESS;
+# ifndef RT_OS_OS2 /* We don't need this on OS/2 and I don't recall if it's actually implemented. */
+            rc = posix_spawnattr_setflags(&Attr, POSIX_SPAWN_SETPGROUP);
+            Assert(rc == 0);
+            if (!rc)
+            {
+                rc = posix_spawnattr_setpgroup(&Attr, 0 /* pg == child pid */);
+                Assert(rc == 0);
+            }
+# endif
+            if (!rc)
+            {
+                /** @todo check if it requires any mandatory attributes or something, don't
+                 *        remember atm. */
+                rc = posix_spawn(&pid, pszExec, NULL, &Attr, (char * const *)papszArgs,
+                                 (char * const *)papszEnv);
+                if (!rc)
+                {
+                    int rc2 = posix_spawnattr_destroy(&Attr); Assert(rc2 == 0); NOREF(rc2);
+                    if (pProcess)
+                        *pProcess = pid;
+                    return VINF_SUCCESS;
+                }
+            }
+            int rc2 = posix_spawnattr_destroy(&Attr); Assert(rc2 == 0); NOREF(rc2);
         }
     }
@@ -131 +157 @@
         if (!pid)
         {
+            setpgid(0, 0); /* see comment above */
+
             if (fFlags & RTPROC_FLAGS_DAEMONIZE)
             {