Changeset 20979 in vbox for trunk/src/VBox/VMM/VMMR0/HWACCMR0.cpp

Timestamp:

Jun 26, 2009 2:56:03 PM (16 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

49187

Message:

Cpu poke never worked in the VT-x/AMD-V case, because pVCpu->idHostCpu was never set.

File:

• trunk/src/VBox/VMM/VMMR0/HWACCMR0.cpp (modified) (5 diffs)

trunk/src/VBox/VMM/VMMR0/HWACCMR0.cpp

@@ -851 +851 @@
         PVMCPU pVCpu = &pVM->aCpus[i];
 
-        pVCpu->hwaccm.s.idEnteredCpu              = NIL_RTCPUID;
-
         /* Invalidate the last cpu we were running on. */
         pVCpu->hwaccm.s.idLastCpu                 = NIL_RTCPUID;
@@ -963 +961 @@
     /* Make sure we can't enter a session after we've disabled hwaccm in preparation of a suspend. */
     AssertReturn(!ASMAtomicReadBool(&HWACCMR0Globals.fSuspended), VERR_HWACCM_SUSPEND_PENDING);
+    Assert(pVCpu->idHostCpu == NIL_RTCPUID);
+
     ASMAtomicWriteBool(&pCpu->fInUse, true);
-
-    AssertMsg(pVCpu->hwaccm.s.idEnteredCpu == NIL_RTCPUID, ("%d", (int)pVCpu->hwaccm.s.idEnteredCpu));
-    pVCpu->hwaccm.s.idEnteredCpu = idCpu;
+    ASMAtomicWriteU32(&pVCpu->idHostCpu, idCpu);
 
     pCtx = CPUMQueryGuestCtxPtr(pVCpu);
@@ -1000 +998 @@
 #endif
     }
-    else
-        pVCpu->hwaccm.s.idEnteredCpu = NIL_RTCPUID;
     return rc;
 }
@@ -1042 +1038 @@
     /* keep track of the CPU owning the VMCS for debugging scheduling weirdness and ring-3 calls. */
 #ifdef RT_STRICT
-    if (RT_UNLIKELY(    pVCpu->hwaccm.s.idEnteredCpu != idCpu
+    if (RT_UNLIKELY(    pVCpu->idHostCpu != idCpu
                     &&  RT_FAILURE(rc)))
     {
-        AssertMsgFailed(("Owner is %d, I'm %d", (int)pVCpu->hwaccm.s.idEnteredCpu, (int)idCpu));
+        AssertMsgFailed(("Owner is %d, I'm %d", (int)pVCpu->idHostCpu, (int)idCpu));
         rc = VERR_INTERNAL_ERROR;
     }
 #endif
-    pVCpu->hwaccm.s.idEnteredCpu = NIL_RTCPUID;
 
     ASMAtomicWriteBool(&pCpu->fInUse, false);
@@ -1200 +1195 @@
         PVMCPU pVCpu = &pVM->aCpus[idCpu];
 
-        if (pVCpu->hwaccm.s.idEnteredCpu == idHostCpu)
+        if (pVCpu->idHostCpu == idHostCpu)
             return pVCpu;
     }