Changeset 1994 in kBuild for trunk/src/kmk/remake.c

Timestamp:

Oct 29, 2008 3:20:22 AM (17 years ago)

Author:

bird

Message:

remake.c: fixed regression from GNU Make head, see Savannah bug #15919.

File:

• trunk/src/kmk/remake.c (modified) (1 diff)

trunk/src/kmk/remake.c

@@ -1169 +1169 @@
           /* Reset this target's state so that we check it fresh.  It could be
              that it's already been checked as part of an order-only
-             prerequisite and so wasn't rebuilt then, but should be now.  */
-          set_command_state (file, cs_not_started);
+             prerequisite and so wasn't rebuilt then, but should be now.
+
+             bird: What if we're already running the recipe?  We don't wish
+                   it to be started once again do we?  This happens with the
+                   SECONDARY Test #9 here now... If the idea is to re-evaluate
+                   the target regardless of whether it's running or no, then
+                   perhaps saving and restoring is a better idea?
+                   See bug #15919.  */
+          if (file->command_state != cs_running) /* bird */
+            set_command_state (file, cs_not_started);
 
           lastd = 0;