VirtualBox

Changeset 7752 in vbox


Ignore:
Timestamp:
Apr 4, 2008 5:35:14 PM (17 years ago)
Author:
vboxsync
svn:sync-xref-src-repo-rev:
29296
Message:

Dropped the pszDesc argument to *MMIORegisterGC/R0. It only persists in the PDMDEVHLP interface now because of binary compatability.

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/include/VBox/iom.h

    r7726 r7752  
    246246
    247247IOMR3DECL(int)  IOMR3MMIORegisterR3(PVM pVM, PPDMDEVINS pDevIns, RTGCPHYS GCPhysStart, RTUINT cbRange, RTHCPTR pvUser,
    248                                     R3PTRTYPE(PFNIOMMMIOWRITE) pfnWriteCallback, R3PTRTYPE(PFNIOMMMIOREAD) pfnReadCallback,
    249                                     R3PTRTYPE(PFNIOMMMIOFILL) pfnFillCallback, const char *pszDesc);
     248                                    R3PTRTYPE(PFNIOMMMIOWRITE) pfnWriteCallback,
     249                                    R3PTRTYPE(PFNIOMMMIOREAD)  pfnReadCallback,
     250                                    R3PTRTYPE(PFNIOMMMIOFILL)  pfnFillCallback, const char *pszDesc);
    250251IOMR3DECL(int)  IOMR3MMIORegisterR0(PVM pVM, PPDMDEVINS pDevIns, RTGCPHYS GCPhysStart, RTUINT cbRange, RTR0PTR pvUser,
    251                                     R0PTRTYPE(PFNIOMMMIOWRITE) pfnWriteCallback, R0PTRTYPE(PFNIOMMMIOREAD) pfnReadCallback,
    252                                     R0PTRTYPE(PFNIOMMMIOFILL) pfnFillCallback, const char *pszDesc);
     252                                    R0PTRTYPE(PFNIOMMMIOWRITE) pfnWriteCallback,
     253                                    R0PTRTYPE(PFNIOMMMIOREAD)  pfnReadCallback,
     254                                    R0PTRTYPE(PFNIOMMMIOFILL)  pfnFillCallback);
    253255IOMR3DECL(int)  IOMR3MMIORegisterGC(PVM pVM, PPDMDEVINS pDevIns, RTGCPHYS GCPhysStart, RTUINT cbRange, RTGCPTR pvUser,
    254                                     GCPTRTYPE(PFNIOMMMIOWRITE) pfnWriteCallback, GCPTRTYPE(PFNIOMMMIOREAD) pfnReadCallback,
    255                                     GCPTRTYPE(PFNIOMMMIOFILL) pfnFillCallback, const char *pszDesc);
     256                                    GCPTRTYPE(PFNIOMMMIOWRITE) pfnWriteCallback,
     257                                    GCPTRTYPE(PFNIOMMMIOREAD)  pfnReadCallback,
     258                                    GCPTRTYPE(PFNIOMMMIOFILL)  pfnFillCallback);
    256259IOMR3DECL(int)  IOMR3MMIODeregister(PVM pVM, PPDMDEVINS pDevIns, RTGCPHYS GCPhysStart, RTUINT cbRange);
    257260/** @} */
  • trunk/include/VBox/pdmdev.h

    r7635 r7752  
    17561756     * @param   pszRead             Name of the GC function which is gonna handle Read operations.
    17571757     * @param   pszFill             Name of the GC function which is gonna handle Fill/memset operations. (optional)
    1758      * @param   pszDesc             Pointer to description string. This must not be freed.
     1758     * @param   pszDesc             Obsolete. NULL is fine.
     1759     * @todo    Remove pszDesc in the next major revision of PDMDEVHLP.
    17591760     */
    17601761    DECLR3CALLBACKMEMBER(int, pfnMMIORegisterGC,(PPDMDEVINS pDevIns, RTGCPHYS GCPhysStart, RTUINT cbRange, RTGCPTR pvUser,
     
    17761777     * @param   pszRead             Name of the GC function which is gonna handle Read operations.
    17771778     * @param   pszFill             Name of the GC function which is gonna handle Fill/memset operations. (optional)
    1778      * @param   pszDesc             Pointer to description string. This must not be freed.
     1779     * @param   pszDesc             Obsolete. NULL is fine.
     1780     * @todo    Remove pszDesc in the next major revision of PDMDEVHLP.
    17791781     */
    17801782    DECLR3CALLBACKMEMBER(int, pfnMMIORegisterR0,(PPDMDEVINS pDevIns, RTGCPHYS GCPhysStart, RTUINT cbRange, RTR0PTR pvUser,
     
    31103112 */
    31113113DECLINLINE(int) PDMDevHlpMMIORegisterGC(PPDMDEVINS pDevIns, RTGCPHYS GCPhysStart, RTUINT cbRange, RTGCPTR pvUser,
    3112                                         const char *pszWrite, const char *pszRead, const char *pszFill, const char *pszDesc)
    3113 {
    3114     return pDevIns->pDevHlp->pfnMMIORegisterGC(pDevIns, GCPhysStart, cbRange, pvUser, pszWrite, pszRead, pszFill, pszDesc);
     3114                                        const char *pszWrite, const char *pszRead, const char *pszFill)
     3115{
     3116    return pDevIns->pDevHlp->pfnMMIORegisterGC(pDevIns, GCPhysStart, cbRange, pvUser, pszWrite, pszRead, pszFill, NULL);
    31153117}
    31163118
     
    31193121 */
    31203122DECLINLINE(int) PDMDevHlpMMIORegisterR0(PPDMDEVINS pDevIns, RTGCPHYS GCPhysStart, RTUINT cbRange, RTR0PTR pvUser,
    3121                                         const char *pszWrite, const char *pszRead, const char *pszFill, const char *pszDesc)
    3122 {
    3123     return pDevIns->pDevHlp->pfnMMIORegisterR0(pDevIns, GCPhysStart, cbRange, pvUser, pszWrite, pszRead, pszFill, pszDesc);
     3123                                        const char *pszWrite, const char *pszRead, const char *pszFill)
     3124{
     3125    return pDevIns->pDevHlp->pfnMMIORegisterR0(pDevIns, GCPhysStart, cbRange, pvUser, pszWrite, pszRead, pszFill, NULL);
    31243126}
    31253127
  • trunk/src/VBox/Devices/Graphics/DevVGA.cpp

    r7685 r7752  
    47274727    if (pData->fGCEnabled)
    47284728    {
    4729         rc = PDMDevHlpMMIORegisterGC(pDevIns, 0x000a0000, 0x00020000, 0, "vgaMMIOWrite", "vgaMMIORead", "vgaMMIOFill", "VGA - VGA Video Buffer");
     4729        rc = PDMDevHlpMMIORegisterGC(pDevIns, 0x000a0000, 0x00020000, 0, "vgaMMIOWrite", "vgaMMIORead", "vgaMMIOFill");
    47304730        if (VBOX_FAILURE(rc))
    47314731            return rc;
     
    47334733    if (pData->fR0Enabled)
    47344734    {
    4735         rc = PDMDevHlpMMIORegisterR0(pDevIns, 0x000a0000, 0x00020000, 0, "vgaMMIOWrite", "vgaMMIORead", "vgaMMIOFill", "VGA - VGA Video Buffer");
     4735        rc = PDMDevHlpMMIORegisterR0(pDevIns, 0x000a0000, 0x00020000, 0, "vgaMMIOWrite", "vgaMMIORead", "vgaMMIOFill");
    47364736        if (VBOX_FAILURE(rc))
    47374737            return rc;
  • trunk/src/VBox/Devices/PC/DevAPIC.cpp

    r6300 r7752  
    17591759    if (fGCEnabled) {
    17601760        rc = PDMDevHlpMMIORegisterGC(pDevIns, pData->apicbase & ~0xfff, 0x1000, 0,
    1761                                      "apicMMIOWrite", "apicMMIORead", NULL, "APIC Memory");
     1761                                     "apicMMIOWrite", "apicMMIORead", NULL);
    17621762        if (VBOX_FAILURE(rc))
    17631763            return rc;
     
    17681768
    17691769        rc = PDMDevHlpMMIORegisterR0(pDevIns, pData->apicbase & ~0xfff, 0x1000, 0,
    1770                                      "apicMMIOWrite", "apicMMIORead", NULL, "APIC Memory");
     1770                                     "apicMMIOWrite", "apicMMIORead", NULL);
    17711771        if (VBOX_FAILURE(rc))
    17721772            return rc;
     
    20372037    if (fGCEnabled) {
    20382038        rc = PDMDevHlpMMIORegisterGC(pDevIns, 0xfec00000, 0x1000, 0,
    2039                                      "ioapicMMIOWrite", "ioapicMMIORead", NULL, "I/O APIC Memory");
     2039                                     "ioapicMMIOWrite", "ioapicMMIORead", NULL);
    20402040        if (VBOX_FAILURE(rc))
    20412041            return rc;
     
    20462046
    20472047        rc = PDMDevHlpMMIORegisterR0(pDevIns, 0xfec00000, 0x1000, 0,
    2048                                      "ioapicMMIOWrite", "ioapicMMIORead", NULL, "I/O APIC Memory");
     2048                                     "ioapicMMIOWrite", "ioapicMMIORead", NULL);
    20492049        if (VBOX_FAILURE(rc))
    20502050            return rc;
  • trunk/src/VBox/VMM/IOM.cpp

    r7751 r7752  
    14871487 * @param   pfnReadCallback     Pointer to function which is gonna handle Read operations.
    14881488 * @param   pfnFillCallback     Pointer to function which is gonna handle Fill/memset operations.
    1489  * @param   pszDesc             Pointer to description string. This must not be freed.
    14901489 */
    14911490IOMR3DECL(int)  IOMR3MMIORegisterGC(PVM pVM, PPDMDEVINS pDevIns, RTGCPHYS GCPhysStart, RTUINT cbRange, RTGCPTR pvUser,
    14921491                                    GCPTRTYPE(PFNIOMMMIOWRITE) pfnWriteCallback, GCPTRTYPE(PFNIOMMMIOREAD) pfnReadCallback,
    1493                                     GCPTRTYPE(PFNIOMMMIOFILL) pfnFillCallback, const char *pszDesc)
    1494 {
    1495     LogFlow(("IOMR3MMIORegisterGC: pDevIns=%p GCPhysStart=%VGp cbRange=%#x pvUser=%VGv pfnWriteCallback=%#x pfnReadCallback=%#x pfnFillCallback=%#x pszDesc=%s\n",
    1496              pDevIns, GCPhysStart, cbRange, pvUser, pfnWriteCallback, pfnReadCallback, pfnFillCallback, pszDesc));
     1492                                    GCPTRTYPE(PFNIOMMMIOFILL) pfnFillCallback)
     1493{
     1494    LogFlow(("IOMR3MMIORegisterGC: pDevIns=%p GCPhysStart=%VGp cbRange=%#x pvUser=%VGv pfnWriteCallback=%#x pfnReadCallback=%#x pfnFillCallback=%#x\n",
     1495             pDevIns, GCPhysStart, cbRange, pvUser, pfnWriteCallback, pfnReadCallback, pfnFillCallback));
    14971496
    14981497    /*
     
    15011500    if (!pfnWriteCallback && !pfnReadCallback)
    15021501    {
    1503         AssertMsgFailed(("No callbacks! %VGp LB%#x %s\n", GCPhysStart, cbRange, pszDesc));
     1502        AssertMsgFailed(("No callbacks! %VGp LB%#x %s\n", GCPhysStart, cbRange));
    15041503        return VERR_INVALID_PARAMETER;
    15051504    }
     
    15411540 * @param   pfnReadCallback     Pointer to function which is gonna handle Read operations.
    15421541 * @param   pfnFillCallback     Pointer to function which is gonna handle Fill/memset operations.
    1543  * @param   pszDesc             Pointer to description string. This must not be freed.
    15441542 */
    15451543IOMR3DECL(int)  IOMR3MMIORegisterR0(PVM pVM, PPDMDEVINS pDevIns, RTGCPHYS GCPhysStart, RTUINT cbRange, RTR0PTR pvUser,
    1546                                     R0PTRTYPE(PFNIOMMMIOWRITE) pfnWriteCallback, R0PTRTYPE(PFNIOMMMIOREAD) pfnReadCallback,
    1547                                     R0PTRTYPE(PFNIOMMMIOFILL) pfnFillCallback, const char *pszDesc)
    1548 {
    1549     LogFlow(("IOMR3MMIORegisterR0: pDevIns=%p GCPhysStart=%VGp cbRange=%#x pvUser=%VHv pfnWriteCallback=%#x pfnReadCallback=%#x pfnFillCallback=%#x pszDesc=%s\n",
    1550              pDevIns, GCPhysStart, cbRange, pvUser, pfnWriteCallback, pfnReadCallback, pfnFillCallback, pszDesc));
     1544                                    R0PTRTYPE(PFNIOMMMIOWRITE) pfnWriteCallback,
     1545                                    R0PTRTYPE(PFNIOMMMIOREAD) pfnReadCallback,
     1546                                    R0PTRTYPE(PFNIOMMMIOFILL) pfnFillCallback)
     1547{
     1548    LogFlow(("IOMR3MMIORegisterR0: pDevIns=%p GCPhysStart=%VGp cbRange=%#x pvUser=%VHv pfnWriteCallback=%#x pfnReadCallback=%#x pfnFillCallback=%#x\n",
     1549             pDevIns, GCPhysStart, cbRange, pvUser, pfnWriteCallback, pfnReadCallback, pfnFillCallback));
    15511550
    15521551    /*
     
    15551554    if (!pfnWriteCallback && !pfnReadCallback)
    15561555    {
    1557         AssertMsgFailed(("No callbacks! %VGp LB%#x %s\n", GCPhysStart, cbRange, pszDesc));
     1556        AssertMsgFailed(("No callbacks! %VGp LB%#x %s\n", GCPhysStart, cbRange));
    15581557        return VERR_INVALID_PARAMETER;
    15591558    }
  • trunk/src/VBox/VMM/PDMDevice.cpp

    r7726 r7752  
    13851385    PDMDEV_ASSERT_DEVINS(pDevIns);
    13861386    VM_ASSERT_EMT(pDevIns->Internal.s.pVMHC);
    1387     LogFlow(("pdmR3DevHlp_MMIORegisterGC: caller='%s'/%d: GCPhysStart=%VGp cbRange=%#x pvUser=%p pszWrite=%p:{%s} pszRead=%p:{%s} pszFill=%p:{%s} pszDesc=%p:{%s}\n",
    1388              pDevIns->pDevReg->szDeviceName, pDevIns->iInstance, GCPhysStart, cbRange, pvUser, pszWrite, pszWrite, pszRead, pszRead, pszFill, pszFill, pszDesc, pszDesc));
     1387    LogFlow(("pdmR3DevHlp_MMIORegisterGC: caller='%s'/%d: GCPhysStart=%VGp cbRange=%#x pvUser=%p pszWrite=%p:{%s} pszRead=%p:{%s} pszFill=%p:{%s}\n",
     1388             pDevIns->pDevReg->szDeviceName, pDevIns->iInstance, GCPhysStart, cbRange, pvUser, pszWrite, pszWrite, pszRead, pszRead, pszFill, pszFill));
    13891389
    13901390    /*
     
    14081408            rc3 = PDMR3GetSymbolGCLazy(pDevIns->Internal.s.pVMHC, pDevIns->pDevReg->szGCMod, pszFill, &GCPtrFill);
    14091409        if (VBOX_SUCCESS(rc) && VBOX_SUCCESS(rc2) && VBOX_SUCCESS(rc3))
    1410             rc = IOMR3MMIORegisterGC(pDevIns->Internal.s.pVMHC, pDevIns, GCPhysStart, cbRange, pvUser, GCPtrWrite, GCPtrRead, GCPtrFill, pszDesc);
     1410            rc = IOMR3MMIORegisterGC(pDevIns->Internal.s.pVMHC, pDevIns, GCPhysStart, cbRange, pvUser, GCPtrWrite, GCPtrRead, GCPtrFill);
    14111411        else
    14121412        {
     
    14371437    PDMDEV_ASSERT_DEVINS(pDevIns);
    14381438    VM_ASSERT_EMT(pDevIns->Internal.s.pVMHC);
    1439     LogFlow(("pdmR3DevHlp_MMIORegisterHC: caller='%s'/%d: GCPhysStart=%VGp cbRange=%#x pvUser=%p pszWrite=%p:{%s} pszRead=%p:{%s} pszFill=%p:{%s} pszDesc=%p:{%s}\n",
    1440              pDevIns->pDevReg->szDeviceName, pDevIns->iInstance, GCPhysStart, cbRange, pvUser, pszWrite, pszWrite, pszRead, pszRead, pszFill, pszFill, pszDesc, pszDesc));
     1439    LogFlow(("pdmR3DevHlp_MMIORegisterHC: caller='%s'/%d: GCPhysStart=%VGp cbRange=%#x pvUser=%p pszWrite=%p:{%s} pszRead=%p:{%s} pszFill=%p:{%s}\n",
     1440             pDevIns->pDevReg->szDeviceName, pDevIns->iInstance, GCPhysStart, cbRange, pvUser, pszWrite, pszWrite, pszRead, pszRead, pszFill, pszFill));
    14411441
    14421442    /*
     
    14601460            rc3 = PDMR3GetSymbolR0Lazy(pDevIns->Internal.s.pVMHC, pDevIns->pDevReg->szR0Mod, pszFill, &pfnR0PtrFill);
    14611461        if (VBOX_SUCCESS(rc) && VBOX_SUCCESS(rc2) && VBOX_SUCCESS(rc3))
    1462             rc = IOMR3MMIORegisterR0(pDevIns->Internal.s.pVMHC, pDevIns, GCPhysStart, cbRange, pvUser, pfnR0PtrWrite, pfnR0PtrRead, pfnR0PtrFill, pszDesc);
     1462            rc = IOMR3MMIORegisterR0(pDevIns->Internal.s.pVMHC, pDevIns, GCPhysStart, cbRange, pvUser, pfnR0PtrWrite, pfnR0PtrRead, pfnR0PtrFill);
    14631463        else
    14641464        {
Note: See TracChangeset for help on using the changeset viewer.

© 2025 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette