Changeset 62264 in vbox

Timestamp:

Jul 14, 2016 4:58:55 PM (9 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

108783

Message:

xpcom: finally remove VBOX_GCC_Wno-delete-non-virtual-dtor as this warning is useful and disabling it would hide potential leaks

Location:

trunk

Files:

• Config.kmk (modified) (1 diff)
• src/libs/xpcom18a4/Config.kmk (modified) (1 diff)
• src/libs/xpcom18a4/xpcom/base/nsISupportsBase.h (modified) (1 diff)
• src/libs/xpcom18a4/xpcom/ds/nsDeque.h (modified) (1 diff)
• src/libs/xpcom18a4/xpcom/tests/TestAutoPtr.cpp (modified) (1 diff)

trunk/Config.kmk

@@ -2642 +2642 @@
         $(QUIET)$(APPEND) '$@' 'endif'
         $(QUIET)$(APPEND) '$@' 'VBOX_GCC_Wno-address           ?= $(call VBOX_GCC_CHECK_CXX,-Wno-address,)'
-        $(QUIET)$(APPEND) '$@' 'VBOX_GCC_Wno-delete-non-virtual-dtor    ?= $(call VBOX_GCC_CHECK_CXX,-Wno-delete-non-virtual-dtor,)'
         $(QUIET)$(APPEND) '$@' 'VBOX_GCC_Wno-int-to-pointer-cast        ?= $(call VBOX_GCC_CHECK_CC,-Wno-int-to-pointer-cast,)'
         $(QUIET)$(APPEND) '$@' 'VBOX_GCC_Wno-invalid-offsetof           ?= $(call VBOX_GCC_CHECK_CXX,-Wno-invalid-offsetof,)'

trunk/src/libs/xpcom18a4/Config.kmk

@@ -41 +41 @@
         $(VBOX_GCC_Wno-invalid-offsetof) -Wno-sign-compare -Wno-unused -Wno-ctor-dtor-privacy \
         $(VBOX_GCC_fvisibility-inlines-hidden) $(VBOX_GCC_fvisibility-hidden) \
-        $(VBOX_GCC_fdiagnostics-show-option) $(VBOX_GCC_Wno-delete-non-virtual-dtor)
+        $(VBOX_GCC_fdiagnostics-show-option)
 TEMPLATE_XPCOM_CXXFLAGS.x86        = -m32
 TEMPLATE_XPCOM_CXXFLAGS.amd64      = -m64

trunk/src/libs/xpcom18a4/xpcom/base/nsISupportsBase.h

@@ -81 +81 @@
 public:
 
+  virtual ~nsISupports() {}
   /**
    * @name Methods

trunk/src/libs/xpcom18a4/xpcom/ds/nsDeque.h

@@ -68 +68 @@
 class nsDequeFunctor{
 public:
+  virtual ~nsDequeFunctor() {}
   virtual void* operator()(void* anObject)=0;
 };

trunk/src/libs/xpcom18a4/xpcom/tests/TestAutoPtr.cpp

@@ -82 +82 @@
 class TestRefObjectBaseB {
     public:
+        virtual ~TestRefObjectBaseB() {}
         int fooB;
         virtual nsrefcnt AddRef() = 0;